8000 state: abort commit if errors have occurred by ehnuje · Pull Request #766 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

state: abort commit if errors have occurred #766

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

ehnuje
Copy link
Contributor
@ehnuje ehnuje commented Nov 20, 2020

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

yoomee1313
yoomee1313 previously approved these changes Nov 20, 2020
KimKyungup
KimKyungup previously approved these changes Nov 20, 2020
aidan-kwon
aidan-kwon previously approved these changes Nov 20, 2020
jeongkyun-oh
jeongkyun-oh previously approved these changes Nov 24, 2020
@aidan-kwon
Copy link
Member

@ehnuje Will you proceed?

8000

@ehnuje ehnuje force-pushed the 1120-geth-21039 branch from 0c9073c to 47b1a1c Compare April 7, 2022 03:06
@ehnuje ehnuje marked this pull request as ready for review April 7, 2022 03:07
@ehnuje ehnuje requested a review from mckim19 as a code owner April 7, 2022 03:07
@ehnuje
Copy link
Contributor Author
ehnuje commented Apr 7, 2022

Now this can be merged since #1279 has been merged into master.
Dear reviewers, could you please review this change?

Copy link
@kjhman21 kjhman21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehnuje ehnuje merged commit ac0003e into klaytn:dev Apr 7, 2022
@ehnuje ehnuje deleted the 1120-geth-21039 branch April 7, 2022 05:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0