This repository was archived by the owner on Aug 19, 2024. It is now read-only.
datasync: fix create kafka topic #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
reviewed
Feb 14, 2022
| @@ -104,7 +104,9 @@ func (k *Kafka) setupTopic(topicName string) error { | |||
|
|
|||
| if err := k.CreateTopic(topicName); err != nil { | |||
| logger.Error("creating a topic is failed", "topicName", topicName, "err", err) | |||
There was a problem hiding this comment.
I think this log needs to be placed before return err.
aidan-kwon
reviewed
Feb 14, 2022
KimKyungup
approved these changes
Feb 21, 2022
jeongkyun-oh
approved these changes
Mar 17, 2022
ehnuje
approved these changes
Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
sarama.ErrTopicAlreadyExistswhen creating a new kafka topic in chaindatafetcherTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
When configured docker compose which contains EN services with chaindatafetcher, some containers failed to start
because topic already exists i.e. concurrency problem :(