This repository was archived by the owner on Aug 19, 2024. It is now read-only.
[Config] Whitespace-able configuration for RPC_API and WS_API #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyunsooda How about adding this to |
jeongkyun-oh
approved these changes
Mar 15, 2022
aidan-kwon
approved these changes
Mar 15, 2022
KimKyungup
approved these changes
Mar 21, 2022
|
If |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
All nodes (
cn,pn, etc) read a corresponding configuration file (xxx.conf)—two options,RPC_APIandWS_APIstand for set multiple RPC options to be enabled. However, the options currently must not have whitespaces. We may improve readability by adding whitespace. This PR enables a configuration file to contain whitespace inRPC_APIandWS_APIproperties.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...