This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Add homi flags to patch genesis AddressBook code #1512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d089aff to
872af8c
Compare
ian0371
approved these changes
Sep 19, 2022
This was referenced Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add
homi setupflags to help test with functioning AddressBook.NOTE: GitHub cannot show diffs of
options.gobecause it's very big.For meaningful diffs, see blukat29/klaytn@be56e1b...blukat29:klaytn:homi-patch-abook-bin.
Background
--cypressand--baobab-testallocates AddressBook contract at address 0x400.constructContract()(AddressBook.sol)Changes
cmd/homi/genesis/options.gotocmd/homi/genesis/bins.go. For future developers.--patch-address-book: Patch the hardcoded address in the genesis AddressBook contract.--patch-address-book-addr: Specify the address to inject in place of the hardcoded address. If not specified, the first CN's address is used.--funding-addr: Give initial funds to the given address. Not directly related to AddressBook, but helps testing. Note that currently homi only give funds to randomly generated addresses according to--cn-numand--test-num.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
Test network setup example
homi setup --cn-num 4 --baobab-test \ --patch-address-book \ --patch-address-book-addr 0x000000000000000000000000000000000000abcd \ --funding-addr 0x000000000000000000000000000000000000abcd \ --docker-image-id klaytn/klaytn:test