This repository was archived by the owner on Aug 19, 2024. It is now read-only.
make baseFee even number #1537
Merged
make baseFee even number #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimni1222
reviewed
Jul 19, 2022
Co-authored-by: Jamie <32922423+jimni1222@users.noreply.github.com>
jimni1222
reviewed
Jul 19, 2022
added 2 commits
July 20, 2022 09:33
jimni1222
reviewed
Jul 20, 2022
ghost
reviewed
Jul 20, 2022
ghost
reviewed
Jul 20, 2022
Co-authored-by: bob.p <106128487+bobpkr@users.noreply.github.com>
Co-authored-by: bob.p <106128487+bobpkr@users.noreply.github.com>
ghost
previously approved these changes
Jul 20, 2022
added 2 commits
July 20, 2022 11:46
jimni1222
reviewed
Jul 20, 2022
ghost
approved these changes
Jul 20, 2022
aidan-kwon
reviewed
Jul 20, 2022
aidan-kwon
approved these changes
Jul 20, 2022
kjhman21
reviewed
Jul 20, 2022
| return baseFee | ||
| } | ||
|
|
||
| func makeEvenByUp(baseFee *big.Int) *big.Int { |
There was a problem hiding this comment.
@kjeom hmm.. name is little bit misleading.
Can we use the name 'ceil' and 'floor' instead?
kjhman21
reviewed
Jul 20, 2022
| @@ -23,10 +23,27 @@ func VerifyMagmaHeader(config *params.ChainConfig, parentHeader, header *types.H | |||
| return nil | |||
| } | |||
|
|
|||
| func makeEvenByDown(baseFee *big.Int) *big.Int { | |||
| if baseFee.Bit(0) != 0 { | |||
| baseFee.Rsh(baseFee, 1) | |||
There was a problem hiding this comment.
I think it would be better to use baseFee.sub()
kjhman21
pushed a commit
to kjhman21/klaytn
that referenced
this pull request
Jul 20, 2022
Refine Implementation of klaytn#1537
|
Refined this code please take a look @kjeom @jimni1222 @bobpkr @aidan-kwon |
Closed
kjhman21
pushed a commit
to kjhman21/klaytn
that referenced
this pull request
Jul 21, 2022
Refine Implementation of klaytn#1537
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)