This repository was archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimni1222
previously approved these changes
<
8000
relative-time datetime="2022-07-19T00:20:38Z" class="no-wrap">Jul 19, 2022
blukat29
previously approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The performance impact (compared to directly using chain.Config()
) should be minimal because ReadGovernance()
is cached.
aidan-kwon
reviewed
Jul 20, 2022
jimni1222
reviewed
Jul 20, 2022
Co-authored-by: Jamie <32922423+jimni1222@users.noreply.github.com>
jimni1222
previously approved these changes
Jul 20, 2022
…ytn into verifyWithTheBlockNumberConfig
jimni1222
approved these changes
Jul 20, 2022
aidan-kwon
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue
TraceBlock
,StandardTraceBlock
) callsVerifyHeader
of consensus engine with latestchainConfig
.KIP-71 config
has been updated, if you call the API with previous block number then it verify the header with latest config, not the config at the block number.Propose
verifyHeader
of the consensus engine.ChainConfig
and update theKIP-71 config
.Notes
ChainConfig
cannot be directly updated because theChainConfig.governance.KIP71Config
is a pointer.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues