This repository was archived by the owner on Aug 19, 2024. It is now read-only.
More validations for tracer output converting logic #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjhman21
reviewed
Jul 22, 2022
|
How about |
Co-authored-by: jk-jeongkyun <45347815+jeongkyun-oh@users.noreply.github.com>
@jeongkyun-oh We should. But, not for this time. Since we are about to release v1.9.0, I don't want to put large changes. This is a kind of hot fixes for recent issues. We need to investigate more about tracers for v1.9.1. |
aidan-kwon
commented
Jul 22, 2022
8538f9d to
db81328
Compare
kjhman21
reviewed
Jul 22, 2022
Co-authored-by: Junghyun Colin Kim <colin.klaytn@krustuniverse.com>
jeongkyun-oh
approved these changes
Jul 22, 2022
kjhman21
approved these changes
Jul 22, 2022
aidan-kwon
pushed a commit
to aidan-kwon/klaytn
that referenced
this pull request
Aug 1, 2022
More validations for tracer output converting logic
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
InternalTxTracer.resultis only called by fastCallTracer now.(fastCallTracer can be used for debug APIs or chaindatafetcher)
The tracer result parses an error string when a transaction is reverted.
Since current logic doesn't have enough validation logic about slice range or overflow/underflow, the tracer can be panic when an abnormal contract executed.
This change introduces only small parts of validation for recent invalid cases.
After v1.9.0 QA, more concrete validation will be introduced later.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)