8000 fixed DoCall for free to transaction with no any price fields by kjeom · Pull Request #1540 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

fixed DoCall for free to transaction with no any price fields #1540

Merged
merged 7 commits into from
Jul 22, 2022
Merged

fixed DoCall for free to transaction with no any price fields #1540

merged 7 commits into from
Jul 22, 2022

Conversation

kjeom
Copy link
@kjeom kjeom commented Jul 20, 2022 •
edited
Loading

Proposed changes

  • Introduction
    • It is for contract call API (eth_call) to be called from user with no any gas price fields (gasPrice, maxFeePerGas)
  • Issue
    • After dynamic gas fee mechanism implemented, It is changed for the evm always to use baseFee.
    • It causes the call API like eth_call to be failed with insufficient balance error.
  • Resolve
    • Add some balance to the validated fee payer as it is done at klay_call.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@kjeom kjeom requested review from ian0371, kjhman21, hqjang-pepper and a user July 20, 2022 10:34
kjhman21
kjhman21 reviewed Jul 20, 2022
View reviewed changes
kjhman21
kjhman21 reviewed Jul 20, 2022
View reviewed changes
@kjeom kjeom added the need to merge Need to merge for the next time label Jul 20, 2022
@kjeom kjeom added this to the v1.9.0 (Magma) milestone Jul 20, 2022
jack and others added 5 commits July 21, 2022 00:18
Update api/api_ethereum.go
2b04509 
Co-authored-by: Junghyun Colin Kim <colin.klaytn@krustuniverse.com>
Update api/api_public_blockchain.go
f6b0e1a 
Co-authored-by: Junghyun Colin Kim <colin.klaytn@krustuniverse.com>
changed the strategy to make the contract call free by addBalance in …
030e446 
…eth_call case
Merge branch 'viewCallForFree' of github.com:kjeom/klaytn into viewCa…
25c1008 
…llForFree
fixed lint error
def45cf
jimni1222
jimni1222 previously approved these changes Jul 20, 2022
View reviewed changes
@2dvorak 2dvorak mentioned this pull request Jul 21, 2022
Closed
ian0371
ian0371 previously approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor
@ian0371 ian0371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with web3's call. thanks

@kjeom kjeom merged commit 2acbccd into klaytn:dev Jul 22, 2022
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian0371 ian0371 ian0371 approved these changes

@kjhman21 kjhman21 kjhman21 approved these changes

@jimni1222 jimni1222 jimni1222 approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@hqjang-pepper hqjang-pepper Awaiting requested review from hqjang-pepper

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh

@ehnuje ehnuje Awaiting requested review from ehnuje

@aeharvlee aeharvlee Awaiting requested review from aeharvlee

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@jiseongnoh jiseongnoh Awaiting requested review from jiseongnoh

@mckim19 mckim19 Awaiting requested review from mckim19

Assignees

@kjeom kjeom

Labels
None yet
Projects
None yet
Milestone
v1.9.0 (Magma)
Development

Successfully merging this pull request may close these issues.
7 participants
@kjeom @ian0371 @kjhman21 @jimni1222 @aidan-kwon @yoomee1313 @blukat29
0