8000 added basefee metric by kjeom · Pull Request #1566 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

added basefee metric #1566

Merged
merged 2 commits into from
Aug 16, 2022
Merged

added basefee metric #1566

merged 2 commits into from
Aug 16, 2022

Conversation

kjeom
Copy link
@kjeom kjeom commented Jul 28, 2022 •
edited
Loading

Proposed changes

  • Added baseFee metric when mining a block in commitNewWork( ).
    • It is for a block producer that do not execute the insertChain.
  • Added baseFee metric when inserting the block in insertChain( ).
    • It is for the other CNs that are not the miner.
  • The printed unit is a ston.
  • It is tested with grafana server.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@kjeom kjeom requested a review from kjhman21 July 28, 2022 09:30
@kjeom kjeom requested a review from JayChoi1736 July 28, 2022 12:04
@kjeom kjeom self-assigned this Jul 29, 2022
@kjeom kjeom added this to the v1.9.1 milestone Jul 29, 2022
@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 16, 2022
@aidan-kwon aidan-kwon merged commit 32bdb23 into klaytn:dev Aug 16, 2022
@aidan-kwon aidan-kwon removed this from the v1.9.2 milestone Aug 18, 2022
aidan-kwon pushed a commit to aidan-kwon/klaytn that referenced this pull request Aug 18, 2022
Merge pull request klaytn#1566 from kjeom/addBaseFeeMetric
f007f66 
added basefee metric
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kjhman21 kjhman21 kjhman21 approved these changes

@hqjang-pepper hqjang-pepper hqjang-pepper approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh

@ehnuje ehnuje Awaiting requested review from ehnuje

@jiseongnoh jiseongnoh Awaiting requested review from jiseongnoh

@yoomee1313 yoomee1313 Awaiting requested review from yoomee1313 yoomee1313 is a code owner

@mckim19 mckim19 Awaiting requested review from mckim19

Assignees

@kjeom kjeom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kjeom @kjhman21 @hqjang-pepper @aidan-kwon @JayChoi1736 @blukat29
0