8000 tracers: add traceBlockByNumberRange by yoomee1313 · Pull Request #1586 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

tracers: add traceBlockByNumberRange #1586

Merged
merged 1 commit into from
Aug 18, 2022
Merged

tracers: add traceBlockByNumberRange #1586

merged 1 commit into from
Aug 18, 2022

Conversation

yoomee1313
Copy link
Contributor
@yoomee1313 yoomee1313 commented Aug 17, 2022 •
edited
Loading

Proposed changes

  • This PR will be open after tracers: refactor tracer api and avoid OOM while tracing #1581 merges. It will be rebased.
  • This PR adds new tracer api, traceBlockByNumberRange. It traces block by range, so docs needs to be edited.
  • The limitation at the return size seems needed but it will be implemented later.
  • By utilizing the implementation of traceChain, traceChain became to have two functions. That is, if Subscription is set, it operates as TraceChain, otherwise it operates as TraceBlockByNumberRange.

Usage

  • suggestion1: set --rpcreadtimeout and --rpcexecutiontimeout EN node flag larger than default(30s).
  • suggestion2: avoid to range too large range depending on node's memory spec
  • suggestion3: recommend to use with curl.
$ curl -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"debug_traceBlockByNumberRange","params":[10,20, {"tracer":"fastCallTracer"}],"id":1}'

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yoomee1313 yoomee1313 self-assigned this Aug 17, 2022
@yoomee1313 yoomee1313 added the need to merge Need to merge for the next time label Aug 17, 2022
@yoomee1313 yoomee1313 force-pushed the traceBlockByNumberRange branch 3 times, most recently from 3539c9c to 2e44be6 Compare August 17, 2022 07:33
@yoomee1313 yoomee1313 force-pushed the traceBlockByNumberRange branch from 2e44be6 to 0469205 Compare August 18, 2022 06:44
@yoomee1313 yoomee1313 marked this pull request as ready for review August 18, 2022 06:55
@yoomee1313
Copy link
Contributor Author

I'll merge this PR. If you have other opinion, feel free to leave a comment here.

@yoomee1313 yoomee1313 merged commit 0b71017 into klaytn:dev Aug 18, 2022
@yoomee1313 yoomee1313 deleted the traceBlockByNumberRange branch August 18, 2022 07:26
aidan-kwon pushed a commit to aidan-kwon/klaytn that referenced this pull request Aug 18, 2022
Merge pull request klaytn#1586 from yoomee1313/traceBlockByNumberRange
bcbc923 
tracers: add traceBlockByNumberRange
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jimni1222 jimni1222 jimni1222 approved these changes

@henry-will henry-will henry-will approved these changes

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@ehnuje ehnuje Awaiting requested review from ehnuje

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

@hqjang-pepper hqjang-pepper Awaiting requested review from hqjang-pepper

@aeharvlee aeharvlee Awaiting requested review from aeharvlee

Assignees

@yoomee1313 yoomee1313

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoomee1313 @jimni1222 @henry-will @JayChoi1736 @blukat29
0