8000 added throttling logic for range fetching by jeongkyun-oh · Pull Request #1583 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

added throttling logic for range fetching #1583

Merged
merged 4 commits into from
Aug 18, 2022
Merged

added throttling logic for range fetching #1583

merged 4 commits into from
Aug 18, 2022

Conversation

jeongkyun-oh
Copy link
Contributor

Proposed changes

It is implemented throttling logic when too large chain event is created while range fetching. The data size is approximately calculated with json marshaling.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

8000
@jeongkyun-oh jeongkyun-oh self-assigned this Aug 16, 2022
@jeongkyun-oh jeongkyun-oh marked this pull request as ready for review August 16, 2022 01:53
@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 16, 2022
@jeongkyun-oh jeongkyun-oh force-pushed the 220816-chaindatafetcher-throttler branch 2 times, most recently from 2effeaa to 324f9bc Compare August 16, 2022 04:38
@jeongkyun-oh jeongkyun-oh force-pushed the 220816-chaindatafetcher-throttler branch from 324f9bc to 1d70a22 Compare August 16, 2022 05:42
hyunsooda
hyunsooda reviewed Aug 16, 2022
View reviewed changes
@jeongkyun-oh jeongkyun-oh requested a review from hyunsooda August 16, 2022 13:40
@aidan-kwon
Copy link
Member

You need to consider #1580 to introduce a new flag

aidan-kwon
aidan-kwon reviewed Aug 17, 2022
View reviewed changes
ethan-kr
ethan-kr approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor
@ethan-kr ethan-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with throttling of "ChainDataFetcher-sendRequests".
Please share the test results later.

@jeongkyun-oh jeongkyun-oh merged commit f8a4223 into klaytn:dev Aug 18, 2022
@jeongkyun-oh jeongkyun-oh deleted the 220816-chaindatafetcher-throttler branch August 18, 2022 01:35
aidan-kwon pushed a commit to aidan-kwon/klaytn that referenced this pull request Aug 18, 2022
@jeongkyun-oh
Merge pull request klaytn#1583 from jeongkyun-oh/220816-chaindatafetc…
1cab6bd 
…her-throttler

added throttling logic for range fetching
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyunsooda hyunsooda hyunsooda approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@ethan-kr ethan-kr ethan-kr approved these changes

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@ehnuje ehnuje Awaiting requested review from ehnuje

@henry-will henry-will Awaiting requested review from henry-will

@nohkwak nohkwak Awaiting requested review from nohkwak

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

Assignees

@jeongkyun-oh jeongkyun-oh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeongkyun-oh @aidan-kwon @hyunsooda @ethan-kr @blukat29
0