8000 Make tracers test not parallel by blukat29 · Pull Request #1591 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Make tracers test not parallel #1591

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Make tracers test not parallel #1591

merged 1 commit into from
Aug 18, 2022

Conversation

blukat29
Copy link
Contributor

Proposed changes

  • Tracers unit tests TestCallTracer and TestInternalCallTracer modifies global state via fork.SetHardForkBlockNumberConfig(). Such tests must not run in parallel.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 requested a review from yoomee1313 August 18, 2022 10:38
@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 18, 2022
@blukat29 blukat29 merged commit 224818c into klaytn:dev Aug 18, 2022
aidan-kwon pushed a commit that referenced this pull request Aug 18, 2022
@blukat29
Merge pull request #1591 from blukat29/tracers-test-not-parallel
7c34497 
Make tracers test not parallel
@blukat29 blukat29 deleted the tracers-test-not-parallel branch August 24, 2022 09:39
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Revi 8049 ewers

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@ehnuje ehnuje Awaiting requested review from ehnuje

@henry-will henry-will Awaiting requested review from henry-will

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

@hqjang-pepper hqjang-pepper Awaiting requested review from hqjang-pepper

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blukat29 @aidan-kwon @yoomee1313
0