This repository was archived by the owner on Aug 19, 2024. It is now read-only.
added snapshot generation asynchronously flag #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-kr
previously approved these changes
Oct 27, 2022
kjhman21
reviewed
Oct 28, 2022
e0d8236 to
4f6e148
Compare
|
@jeongkyun-oh Uhoh, you need to resolve the conflict. |
4f6e148 to
09989ed
Compare
|
@kjhman21 I have rebased. PTAL. |
hqjang-pepper
approved these changes
Nov 1, 2022
aidan-kwon
reviewed
Nov 2, 2022
| @@ -312,6 +312,7 @@ var FlagGroups = []FlagGroup{ | |||
| KESNodeTypeServiceFlag, | |||
| SnapshotFlag, | |||
| SnapshotCacheSizeFlag, | |||
| SnapshotAsyncGen, | |||
There was a problem hiding this comment.
I think it can be moved to Database category.
There was a problem hiding this comment.
Maybe all snapshot flags can be moved. I will make another PR for this.
aidan-kwon
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When
--snapshotflag is set, the snapshot layer is generated after stopping block processing. This PR added a snapshot generation flag in order to generate snapshot data in a background while block processing normally.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)