8000 added ntp check routine by kjeom · Pull Request #1641 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

added ntp check routine #1641

Merged
merged 2 commits into from
Oct 27, 2022
Merged

added ntp check routine #1641

merged 2 commits into from
Oct 27, 2022

Conversation

kjeom
Copy link
@kjeom kjeom commented Oct 13, 2022 •
edited
Loading

Proposed changes

  • Added ntp time check routine.
  • Issue
    • Klaytn use system time method like now().
    • If the system time is out of sync, It will not be run as intended.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@kjeom kjeom self-assigned this Oct 13, 2022
kjhman21
kjhman21 reviewed Oct 17, 2022
View reviewed changes
@kjhman21 kjhman21 mentioned this pull request Oct 20, 2022
Closed
2dvorak
2dvorak approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator
@2dvorak 2dvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time.nist.gov was not working, I had to test with another NTP server.

@kjeom kjeom merged commit 7516d63 into klaytn:dev Oct 27, 2022
This was referenced Nov 7, 2022
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@2dvorak 2dvorak 2dvorak approved these changes

@kjhman21 kjhman21 kjhman21 approved these changes

@hqjang-pepper hqjang-pepper hqjang-pepper approved these changes

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

@henry-will henry-will Awaiting requested review from henry-will

@nohkwak nohkwak Awaiting requested review from nohkwak

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh

Assignees

@kjeom kjeom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjeom @2dvorak @kjhman21 @hqjang-pepper
0