This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Seperate trie commit and hash #1656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2022
…perate-trie-commit-and-hash
Benchmark Hash and commit
|
|
The reason that the execution time of the hash function is longer than expected is because parallel processing is removed from this part of code. This was rolled back in PR #1659, and you can see that the performance improvement occurred in that PR. |
9 tasks
Comment on lines
+237
to
+241
| // For children in range [0, 15], it's impossible | ||
| // to contain valueNode. Only check the 17th child. | ||
| if n.Children[16] != nil { | ||
| c.onleaf(nil, nil, n.Children[16].(valueNode), hash, 0) | ||
| } |
There was a problem hiding this comment.
Are you sure about this? Would you mind to take a look insert method of Trie?
Please let me know if I'm wrong.
_, branch.Children[n.Key[matchlen]], err = t.insert(nil, append(prefix, n.Key[:matchlen+1]...), n.Key[matchlen+1:], n.Val)
There was a problem hiding this comment.
Yes I think there's no specific problem in here.
Same as the existing onleaf method.
|
@kjhman21 Was this PR milestone changed to v1.11? |
8000
|
@hqjang-pepper yes. |
|
Won't do in this version. closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Seperate Trie committer and hasher
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...