8000 Gather DeriveSha codes under derivesha package by blukat29 · Pull Request #1689 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Gather DeriveSha codes under derivesha package #1689

Merged
merged 6 commits into from
Nov 15, 2022
Merged

Gather DeriveSha codes under derivesha package #1689

merged 6 commits into from
Nov 15, 2022

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Nov 11, 2022 •
edited
Loading

Proposed changes

  • Move DeriveSha implementation codes under a new blockchain/types/derivesha package.
  • This change is a cosmetic refactoring before the upcoming dynamic DeriveShaImpl feature.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

#1687

Further comments

@blukat29 blukat29 added this to the v1.10 (Kore) milestone Nov 11, 2022
@blukat29 blukat29 self-assigned this Nov 11, 2022
@blukat29 blukat29 mentioned this pull request Nov 11, 2022
Closed
@blukat29 blukat29 marked this pull request as ready for review November 11, 2022 09:49
hqjang-pepper
hqjang-pepper previously approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor
@hqjang-pepper hqjang-pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blukat29 blukat29 mentioned this pull request Nov 15, 2022
Merged
9 tasks
kjhman21
kjhman21 previously approved these changes Nov 15, 2022
View reviewed changes
jeongkyun-oh
jeongkyun-oh reviewed Nov 15, 2022
View reviewed changes
jeongkyun-oh
jeongkyun-oh reviewed Nov 15, 2022
View reviewed changes
jeongkyun-oh
jeongkyun-oh previously approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor
@jeongkyun-oh jeongkyun-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minors

@blukat29 blukat29 merged commit 473ddc0 into klaytn:dev Nov 15, 2022
@blukat29 blukat29 deleted the refactor-derivesha-imports branch November 16, 2022 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian0371 ian0371 ian0371 approved these changes

@jeongkyun-oh jeongkyun-oh jeongkyun-oh approved these changes

@kjhman21 kjhman21 kjhman21 left review comments

@hqjang-pepper hqjang-pepper hqjang-pepper left review comments

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@ethan-kr ethan-kr Awaiting requested review from ethan-kr

@ehnuje ehnuje Awaiting requested review from ehnuje

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
v1.10.0 (Kore)
Development

Successfully merging this pull request may close these issues.
5 participants
@blukat29 @ian0371 @kjhman21 @jeongkyun-oh @hqjang-pepper
0