This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Fix reward miscalculation under RoundRobin policy #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fccfefd to
75c2ccb
Compare
jiseongnoh
reviewed
Nov 21, 2022
| // config.Istanbul must have been set | ||
| func IsRewardSimple(config *params.ChainConfig) bool { | ||
| policy := config.Istanbul.ProposerPolicy | ||
| return policy != uint64(istanbul.WeightedRandom) |
There was a problem hiding this comment.
I guess this code was meant to check the mainnet. Maybe we can refactor this some day...
jiseongnoh
approved these changes
Nov 21, 2022
blukat29
approved these changes
Nov 21, 2022
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR
Before Kore, there was a bug that distributed txFee at the end of block proecessing regardless of
deferredTxFeeflag.See #1692.
To maintain backward compatibility, we only fix the buggy logic after Kore and leave the buggy logic before Kore.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...