8000 Disable VM Standard Tracing APIs in debug namespace by 2dvorak · Pull Request #1722 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Disable VM Standard Tracing APIs in debug namespace #1722

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Disable VM Standard Tracing APIs in debug namespace #1722

merged 1 commit into from
Nov 23, 2022

Conversation

2dvorak
Copy link
Collaborator
@2dvorak 2dvorak commented Nov 23, 2022

Proposed changes

  • VM Standard Tracing APIs (standardTraceBlockToFile, standardTraceBadBlockToFile) write results in local file
  • The debug namespace is to provided developer-friendly APIs over RPC in public ENs, and it is meaningless to provide VM Standard Tracing APIs over RPC (because they write results in local file)
  • This PR disables VM Standard Tracing APIs in debug namespace (however they still remain in the unsafedebug namespace).

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

None

@2dvorak
Remove VM Standard Tracing APIs from debug namespace
ecb5699 
Those APIs write result to local file, which is meaningless to be
provided over RPC.
@2dvorak 2dvorak added this to the v1.10 (Kore) milestone Nov 23, 2022
@2dvorak 2dvorak self-assigned this Nov 23, 2022
@yoomee1313 yoomee1313 added the need to merge Need to merge for the next time label Nov 23, 2022
@2dvorak 2dvorak merged commit 9d6a0e9 into klaytn:dev Nov 23, 2022
@2dvorak 2dvorak deleted the disable-vm-standard-tracing-in-debug-namespace branch November 23, 2022 09:12
@blukat29 blukat29 mentioned this pull request Nov 28, 2022
Closed
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Nov 28, 2022
@blukat29 blukat29 mentioned this pull request Dec 1, 2022
Closed
31 tasks
@ian0371 ian0371 mentioned this pull request Feb 24, 2023
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyunsooda hyunsooda hyunsooda approved these changes

@henry-will henry-will henry-will approved these changes

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@ehnuje ehnuje Awaiting requested review from ehnuje

Assignees

@2dvorak 2dvorak

Labels
None yet
Projects
None yet
Milestone
v1.10.0 (Kore)
Development

Successfully merging this pull request may close these issues.
5 participants
@2dvorak @hyunsooda @henry-will @blukat29 @yoomee1313
0