10000 Remove kip82ratio from homi --cypress output by ian0371 · Pull Request #1734 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Remove kip82ratio from homi --cypress output #1734

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Remove kip82ratio from homi --cypress output #1734

merged 5 commits into from
Dec 6, 2022

Conversation

ian0371
Copy link
Contributor
@ian0371 ian0371 commented Dec 2, 2022 •
edited
Loading

Proposed changes

If homi is run with one of --cypress, --cypress-test, --baobab, or --baobab-test, it generates genesis.json with kip82ratio.

$ homi setup local --cypress --cn-num 1
$ cat homi-output/scripts/genesis.json
...
        "governance": {
            "reward": {
...
                "kip82ratio": "20/80",
...
            }
        }
...

It can be confusing because CypressChainConfig in params/config.go does not have these fields.
This PR thus removes these fields from the homi output when invoked with the kip82ratio flags.

  • remove the field from genCypressCommonGenesis and genBaobabCommonGenesis
  • add a tag omitempty to params.ChainConfig (otherwise, the output will contain an empty string)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

The reason for excluding GovParamContract is as follows.

Therefore, we'll just let GovParamContract appear in the genesis.json as is
@ian0371 ian0371 self-assigned this Dec 2, 2022
@ian0371 ian0371 added this to the v1.10 (Kore) milestone Dec 2, 2022
@ian0371 ian0371 requested review from kjeom and blukat29 December 2, 2022 08:42
@kjhman21 kjhman21 added the need to merge Need to merge for the next time label Dec 5, 2022
@blukat29 blukat29 mentioned this pull request Dec 5, 2022
Closed
@ian0371 ian0371 changed the title Remove some params from homi output Remove kip82ratio from homi --cypress output Dec 5, 2022
@ian0371 ian0371 merged commit 57d4c45 into klaytn:dev Dec 6, 2022
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Dec 6, 2022
@blukat29 blukat29 mentioned this pull request Dec 15, 2022
Closed
31 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@kjeom kjeom kjeom approved these changes

@2dvorak 2dvorak 2dvorak approved these changes

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@henry-will henry-will Awaiting requested review from henry-will

@nohkwak nohkwak Awaiting requested review from nohkwak

Assignees

@ian0371 ian0371

Labels
None yet
Projects
None yet
Milestone
v1.10.0 (Kore)
Development

Successfully merging this pull request may close these issues.
5 participants
@ian0371 @blukat29 @kjeom @2dvorak @kjhman21
0