8000 Add evm execution timeout by kjeom · Pull Request #1736 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Add evm execution timeout #1736

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Add evm execution timeout #1736

merged 6 commits into from
Dec 9, 2022

Conversation

kjeom
Copy link
@kjeom kjeom commented Dec 6, 2022

Proposed changes

  • This PR implements RPCEVMTimeout
  • It's implemented in case you have RPCs that run longer than 5 seconds.
  • How to use
    • add ADDITIONAL="--rpc.evmtimeout 10s" in kxxd.conf file

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@kjeom kjeom self-assigned this Dec 6, 2022
@kjeom kjeom mentioned this pull request Dec 6, 2022
Closed
@kjhman21 kjhman21 added the need to merge Need to merge for the next time label Dec 7, 2022
nohkwak
nohkwak previously approved these changes Dec 7, 2022
View reviewed changes
@JayChoi1736
Copy link
Contributor

i've got

ken flag redefined: rpc.evmtimeout
panic: ken flag redefined: rpc.evmtimeout

on ken init.( the binary was builded on local m1 mac)

@kjeom
Copy link
Author
kjeom commented Dec 7, 2022

i've got

ken flag redefined: rpc.evmtimeout
panic: ken flag redefined: rpc.evmtimeout

on ken init.( the binary was builded on local m1 mac)

Thanks, the flag should be removed at KENFlags in cmd/utils/nodecmd/nodeflags.go

JayChoi1736
JayChoi1736 reviewed Dec 8, 2022
View reviewed changes
@blukat29 blukat29 mentioned this pull request Dec 9, 2022
Closed
@kjeom kjeom merged commit b0bf10f into klaytn:dev Dec 9, 2022
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Dec 13, 2022
@blukat29 blukat29 added this to the v1.10 (Kore) milestone Dec 14, 2022
@blukat29 blukat29 mentioned this pull request Dec 15, 2022
Closed
31 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nohkwak nohkwak nohkwak approved these changes

@henry-will henry-will henry-will approved these changes

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

@KimKyungup KimKyungup Awaiting requested review from KimKyungup

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@ehnuje ehnuje Awaiting requested review from ehnuje

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@jimni1222 jimni1222 Awaiting requested review from jimni1222

Assignees

@kjeom kjeom

Labels
None yet
Projects
None yet
Milestone
v1.10.0 (Kore)
Development

Successfully merging this pull request may close these issues.
6 participants
@kjeom @JayChoi1736 @nohkwak @henry-will @blukat29 @kjhman21
0