This repository was archived by the owner on Aug 19, 2024. It is now read-only.
added API function aliases (chainConfig, chainConfigAt) #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e have been moved to klay namespace as well
ian0371
reviewed
Nov 29, 2022
console/web3ext/web3ext.go
Outdated
| new web3._extend.Method({ | ||
| name: 'chainConfig', | ||
| call: 'klay_chainConfig', | ||
| params: 0, |
There was a problem hiding this comment.
Since governance.chainConfig is a property, not a function, I think we should implement this as a property.
blukat29
reviewed
Nov 29, 2022
ian0371
previously approved these changes
Nov 29, 2022
|
@kjeom @ian0371 Let's provide more governance APIs in
|
…ace have been copied to klay namespace
9 tasks
ian0371
approved these changes
Dec 2, 2022
JayChoi1736
approved these changes
Dec 2, 2022
blukat29
approved these changes
Dec 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid becau
2F6D
se no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
chainConfig,chainConfigAt) fromgovernancenamespace have been copied toklaynamespace for aliases.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)