8000 Fix docker publish failures by aidan-kwon · Pull Request #1769 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Fix docker publish failures #1769

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Fix docker publish failures #1769

merged 2 commits into from
Jan 27, 2023

Conversation

aidan-kwon
Copy link
Member
@aidan-kwon aidan-kwon commented Jan 27, 2023 •
edited
Loading

Proposed changes

CircleCI is failing to publish a docker image because of two kinds of reasons (case):

  1. missing /
Step 15/27 : COPY go.mod go.sum .
When using COPY with more than one source file, the destination must be a directory and end with a /`
  1. Docker BuildKit not enabled
Step 17/28 : RUN --mount=type=cache,target=/go/pkg/mod go mod download -x
the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled

Changes

  1. Add / in Dockerfile
  2. Add environment variable DOCKER_BUILDKIT=1 in circleci/config.yml

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@aidan-kwon aidan-kwon self-assigned this Jan 27, 2023
@aidan-kwon aidan-kwon force-pushed the 230127-circleCI branch 2 times, most recently from 8c652a9 to dd9a662 Compare January 27, 2023 07:40
@aidan-kwon aidan-kwon force-pushed the 230127-circleCI branch 6 times, most recently from 384ff28 to 93e5a58 Compare January 27, 2023 08:57
@aidan-kwon
Copy link
Member Author

Test result (canceled during the docker image uploading): https://app.circleci.com/pipelines/github/klaytn/klaytn/9217/workflows/44c58353-2a8b-4afe-80c7-240decea771d/jobs/49718

8000

@aidan-kwon aidan-kwon merged commit 35a074c into klaytn:dev Jan 27, 2023
@aidan-kwon aidan-kwon deleted the 230127-circleCI branch January 27, 2023 09:25
@blukat29 blukat29 added this to the v1.10.2 milestone Feb 22, 2023
@aidan-kwon aidan-kwon mentioned this pull request Feb 23, 2023
Closed
@blukat29 blukat29 mentioned this pull request Mar 3, 2023
Closed
9 tasks
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
Closed
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@ian0371 ian0371 ian0371 approved these changes

@kjhman21 kjhman21 Awaiting requested review from kjhman21

@kjeom kjeom Awaiting requested review from kjeom

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@iv0rish iv0rish Awaiting requested review from iv0rish

Assignees

@aidan-kwon aidan-kwon

Labels
None yet
Projects
None yet
Milestone
v1.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@aidan-kwon @blukat29 @ian0371
0