This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Change snapshot's EffectiveParams argument number #1791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiseongnoh
reviewed
Feb 24, 2023
jiseongnoh
approved these changes
Feb 24, 2023
blukat29
approved these changes
Feb 24, 2023
hyunsooda
reviewed
Feb 24, 2023
| @@ -156,7 +156,7 @@ func (s *Snapshot) apply(headers []*types.Header, gov governance.Engine, addr co | |||
| snap := s.copy() | |||
|
|
|||
| // Copy values which might be changed by governance vote | |||
| snap.Epoch, snap.Policy, snap.CommitteeSize = getGovernanceValue(gov, snap.Number) | |||
| snap.Epoch, snap.Policy, snap.CommitteeSize = effectiveParams(gov, snap.Number+1) | |||
There was a problem hiding this comment.
This line appears to be unnecessary. As it has already been merged, please take it into consideration at a later time.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change number to number + 1 because
snapshot(N)is used to generate N+1 block.Also, governance parameters can change every block, so
effectiveParamsneed to be called every block.These fix
istanbul.committeesizeactivation timing tok*epochafter Kore.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...