Stop loading rewardwallet #1819
Conversation
|
You have successfully added a new CodeQL configuration |
|
Tested with the following scenarios
LGTM |
{{ message }}
This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dvorak
approved these changes
May 10, 2023
aidan-kwon
approved these changes
May 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Klaytn consensus node does not need the wallet (private key) for rewardbase address, yet it tries to load it from accounts.
Klaytn prints an irrelevant log "Error happened while setting the reward wallet" during node startup.
Therefore this PR
rewardwallet) from Klaytn codebase.In the diagram below, red boxes are the ones removed.
flowchart LR flag{{--rewardbase 0xaddr}} -->|cn.Config.Rb| cn.New("cn.New()") cn.New -->|cn.rb| cn.setRW cn.New -->|cn.Config.Rb| CreateConsensusEngine CreateConsensusEngine --> istanbulBackend.New istanbulBackend.New --> sb.rb api.Rb("rpc klay_rewardbase") --> cn.Rb subgraph type cn.ProtocolManager pm.Set --> pm.rb{{pm.rewardbase}} pm.Set --> pm.rw{{pm.rewardwallet}} end subgraph type cn.CN cn.setRW("setRewardWallet()") --> cn.RbW("RewardbaseWallet()") cn.setRW --> pm.Set("pm.SetRb(), pm.SetRbW()") cn.SetRb("SetRewardbase()") --> cn.RbW cn.SetRb --> pm.Set cn.RbW --> cn.Rb("Rewardbase()") cn.Rb <--> cn.rb{{cn.rb}} end subgraph type istanbul.backend sb.rb{{sb.rewardbase}} sb.rb --> ib.Prepare("Prepare()") sb.rb --> ib.GetRB("GetRewardBase()") end classDef red fill:#fcc class cn.setRW,cn.RbW,pm.rb,pm.rw,pm.Set,cn.SetRb redTypes of changes
Checklist
$ make test)Related issues
Further comments