8000 Add BlockchainContractCaller by blukat29 · Pull Request #1828 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Add BlockchainContractCaller #1828

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Add BlockchainContractCaller #1828

merged 11 commits into from
Jul 14, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Apr 18, 2023 •
edited
Loading

Proposed changes

Add BlockchainContractCaller that implements bind.ContractCaller based on live BlockChain instance. Note that SimulatedBackend creates a temporary BlockChain, so it's only useful for testing. However, BlockchainContractCaller wraps an existing BlockChain, so it can be used in block processing.

Replaced by BlockchainContractCaller

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 self-assigned this Apr 18, 2023
@blukat29 blukat29 added this to the v1.11 (Mantle) milestone Apr 18, 2023
@blukat29 blukat29 force-pushed the contractcaller-blockchain branch 6 times, most recently from f05db79 to 6a29938 Compare April 21, 2023 07:28
@2dvorak 2dvorak force-pushed the contractcaller-blockchain branch 2 times, most recently from 6dac514 to 4d1aadf Compare June 26, 2023 08:35
@2dvorak 2dvorak force-pushed the contractcaller-blockchain branch from 4d1aadf to 4b99a04 Compare June 26, 2023 08:35
@2dvorak 2dvorak marked this pull request as ready for review June 26, 2023 09:35
ian0371
ian0371 reviewed Jun 28, 2023
View reviewed changes
blukat29
blukat29 commented Jun 28, 2023
View reviewed changes
blukat29
blukat29 commented Jun 28, 2023
View reviewed changes
yoomee1313
yoomee1313 reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor
@yoomee1313 yoomee1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me except for one minor thing.

ian0371
ian0371 previously approved these changes Jul 4, 2023
View reviewed changes
yoomee1313
yoomee1313 previously approved these changes Jul 4, 2023
View reviewed changes
kjeom
kjeom reviewed Jul 11, 2023
View reviewed changes
jiseongnoh
jiseongnoh reviewed Jul 11, 2023
View reviewed changes
@2dvorak 2dvorak dismissed stale reviews from yoomee1313 and ian0371 via 9f5f12d July 13, 2023 01:23
@2dvorak 2dvorak force-pushed the contractcaller-blockchain branch from 9f5f12d to 8e1bf34 Compare July 13, 2023 01:25
@2dvorak 2dvorak requested review from yoomee1313, ian0371 and kjeom July 13, 2023 01:28
@blukat29 blukat29 mentioned this pull request Jul 13, 2023
Merged
9 tasks
@2dvorak 2dvorak merged commit c0f426b into klaytn:dev Jul 14, 2023
@2dvorak 2dvorak deleted the contractcaller-blockchain branch July 14, 2023 16:09
aidan-kwon
aidan-kwon reviewed Jul 17, 2023
View reviewed changes
aidan-kwon
aidan-kwon reviewed Jul 17, 2023
View reviewed changes
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
Closed
20 tasks
@2dvorak 2dvorak mentioned this pull request Jul 25, 2023
Merged
9 tasks
@2dvorak 2dvorak mentioned this pull request Aug 21, 2023
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@2dvorak 2dvorak 2dvorak left review comments

@jiseongnoh jiseongnoh jiseongnoh left review comments

@aidan-kwon aidan-kwon aidan-kwon left review comments

@ian0371 ian0371 ian0371 approved these changes

@kjeom kjeom kjeom approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

Assignees

@blukat29 blukat29

@2dvorak 2dvorak

Labels
None yet
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@blukat29 @ian0371 @kjeom @2dvorak @jiseongnoh @aidan-kwon @yoomee1313
0