8000 [Validator] Tidy-up of consolidated staking amount calculator by hyunsooda · Pull Request #1856 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

[Validator] Tidy-up of consolidated staking amount calculator #1856

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

hyunsooda
Copy link
Contributor
@hyunsooda hyunsooda commented May 31, 2023

Proposed changes

The current implementation readability of the consolidated staking calculator is quite poor. This PR aims to improve readability by tidying up the code to a minimal and more easily understandable state. This PR was inspired by the @ian0371's comment

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Jul 24, 2023
@CLAassistant
Copy link
CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@Sotatek-TinnNguyen
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
20 tasks
@aidan-kwon
Copy link
Member

@hyunsooda I am gonna merge this PR. If you have any concern about this, please let me know

@aidan-kwon aidan-kwon merged commit e5048fe into klaytn:dev Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need to merge Need to merge for the next time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0