8000 Deprecate APIs by ian0371 · Pull Request #1860 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Deprecate APIs #1860

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Deprecate APIs #1860

merged 2 commits into from
Jun 14, 2023

Conversation

ian0371
Copy link
Contributor
@ian0371 ian0371 commented Jun 13, 2023

Proposed changes

This PR is a follow-up of #1783. Please see #1783 before review.

Deprecate APIs:

  • governance_itemsAt
  • governance_chainConfigAt
  • governance_chainConfig
  • klay_govParamsAt
  • klay_chainConfigAt
  • klay_chainConfig
  • klay_gasPriceAt

See further comments for replacing klay_gasPriceAt.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

Current return value of klay_gasPriceAt (according to docs):

  1. If baseFee is undefined in the header, it returns the unit price from the governance parameter
  2. If the block is a pending block, it returns the gas price of the txpool.
  3. Otherwise, it returns the base fee of the given block.

Users can replace each usage by:

  1. using klay_getParams
  2. using klay_gasPrice
  3. using baseFeePerGas field from klay_getBlockByNumber

@ian0371 ian0371 self-assigned this Jun 13, 2023
@kjeom
Copy link
kjeom commented Jun 13, 2023 •
edited
Loading

These changes only will be reflected in web3klaytn, not in caver.

@ian0371 ian0371 marked this pull request as ready for review June 13, 2023 06:02
@ian0371 ian0371 merged commit c93e569 into klaytn:dev Jun 14, 2023
@ian0371 ian0371 deleted the fork/deprecate-apis branch June 14, 2023 00:39
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
Closed
20 tasks
@sjnam sjnam mentioned this pull request Sep 11, 2023
Closed
@kjeom kjeom mentioned this pull request Oct 27, 2023
Merged
9 tasks
@nohkwak nohkwak mentioned this pull request Oct 27, 2023
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@kjeom kjeom kjeom approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

@nohkwak nohkwak Awaiting requested review from nohkwak

Assignees

@ian0371 ian0371

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ian0371 @kjeom @blukat29 @yoomee1313 @JayChoi1736
0