8000 vm: setup mantle hardfork(protocol upgrade) and add new PUSH0 opcode by yoomee1313 · Pull Request #1861 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

vm: setup mantle hardfork(protocol upgrade) and add new PUSH0 opcode #1861

Merged
merged 4 commits into from
Jun 26, 2023
Merged

vm: setup mantle hardfork(protocol upgrade) and add new PUSH0 opcode #1861

merged 4 commits into from
Jun 26, 2023

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yoomee1313 yoomee1313 self-assigned this Jun 14, 2023
@yoomee1313 yoomee1313 marked this pull request as ready for review June 14, 2023 04:57
@yoomee1313 yoomee1313 closed this Jun 14, 2023
@yoomee1313 yoomee1313 reopened this Jun 14, 2023
@yoomee1313 yoomee1313 closed this Jun 14, 2023
@yoomee1313 yoomee1313 reopened this Jun 14, 2023
blukat29
blukat29 previously approved these changes Jun 14, 2023
View reviewed changes
hyunsooda
hyunsooda reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor
@hyunsooda hyunsooda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follow-up PR is commendable. I have verified that incorporating the PUSH0 instruction significantly reduces the contract size, making it an excellent feature.

ian0371
ian0371 reviewed Jun 14, 2023
View reviewed changes
@yoomee1313 yoomee1313 requested a review from hyunsooda June 19, 2023 02:02
blukat29
blukat29 previously approved these changes Jun 20, 2023
View reviewed changes
hyunsooda
hyunsooda previously approved these changes Jun 21, 2023
View reviewed changes
@yoomee1313 yoomee1313 dismissed stale reviews from hyunsooda and blukat29 via f112f89 June 21, 2023 02:08
@yoomee1313 yoomee1313 merged commit 3eeba18 into klaytn:dev Jun 26, 2023
@yoomee1313 yoomee1313 deleted the push0 branch June 26, 2023 08:33
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
Closed
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@ian0371 ian0371 ian0371 approved these changes

@kjeom kjeom Awaiting requested review from kjeom

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

Assignees

@yoomee1313 yoomee1313

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoomee1313 @blukat29 @ian0371 @hyunsooda @aidan-kwon
0