8000 RPC admin_exportChain accepts first, last block numbers by blukat29 · Pull Request #1873 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

RPC admin_exportChain accepts first, last block numbers #1873

Merged
merged 1 commit into from
Jul 17, 2023
Merged

RPC admin_exportChain accepts first, last block numbers #1873

merged 1 commit into from
Jul 17, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Jul 1, 2023

Proposed changes

Following the geth change ethereum/go-ethereum#20107,
the admin_exportChain RPC optionally accepts the first and last block numbers to export a range of blocks.

Console example:

admin.exportChain("chain01")  // entire chain
admin.exportChain("chain01", 555)   // 555 to the end
admin.exportChain("chain01", 1, 1000)   // 1 to 1000, inclusive.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 force-pushed the exportchain-range branch from 9ecae2e to d77f205 Compare July 1, 2023 06:18
@blukat29 blukat29 self-assigned this Jul 1, 2023
hyunsooda
hyunsooda approved these changes Jul 4, 2023
View reviewed changes
@blukat29 blukat29 merged commit 281e75f into klaytn:dev Jul 17, 2023
@blukat29 blukat29 deleted the exportchain-range branch July 17, 2023 01:02
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
Closed
20 tasks
@kjeom kjeom mentioned this pull request Oct 27, 2023
Merged
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyunsooda hyunsooda hyunsooda approved these changes

@kjeom kjeom kjeom approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@nohkwak nohkwak Awaiting requested review from nohkwak

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blukat29 @hyunsooda @kjeom @yoomee1313
0