8000 build: update dd-trace-go.v1 to v1.42.0 by yoomee1313 · Pull Request #1880 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

build: update dd-trace-go.v1 to v1.42.0 #1880

Merged
merged 1 commit into from
Jul 17, 2023
Merged

build: update dd-trace-go.v1 to v1.42.0 #1880

merged 1 commit into from
Jul 17, 2023

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

  • If we run the klaytn binary built with go1.19+, we get the next panic error and program halted.
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, 
but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. 
If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. 
Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yoomee1313 yoomee1313 requested a review from aidan-kwon as a code owner July 17, 2023 06:38
@yoomee1313 yoomee1313 self-assigned this Jul 17, 2023
aidan-kwon
aidan-kwon approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member
@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider updating the minimum go version in go.mod file. In the current context, it should be 1.19 or above

@yoomee1313 yoomee1313 merged commit aab8797 into klaytn:dev Jul 17, 2023
@yoomee1313 yoomee1313 deleted the update-dd-trace-go.v1 branch July 17, 2023 10:47
@aidan-kwon aidan-kwon mentioned this pull request Aug 3, 2023
Closed
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@kjeom kjeom Awaiting requested review from kjeom

Assignees

@yoomee1313 yoomee1313

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoomee1313 @blukat29 @aidan-kwon
0