8000 Update klaytn_base image golang from 1.18 to 1.20.6 by Sotatek-TinnNguyen · Pull Request #1898 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Update klaytn_base image golang from 1.18 to 1.20.6 #1898

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Update klaytn_base image golang from 1.18 to 1.20.6 #1898

merged 3 commits into from
Jul 26, 2023

Conversation

Sotatek-TinnNguyen
Copy link
Contributor
@Sotatek-TinnNguyen Sotatek-TinnNguyen commented Jul 26, 2023 •
edited
Loading

Proposed changes

  • Upgrade the klaytn_base and klaytn_rpm image from go 1.18 to 1.20.6
  • Change the AWS cli from version 1 to 2 in klaytn_base

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Sotatek-TinnNguyen Sotatek-TinnNguyen self-assigned this Jul 26, 2023
aidan-kwon
aidan-kwon reviewed Jul 26, 2023
View reviewed changes
aidan-kwon
aidan-kwon approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member
@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a minor thing

@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Jul 26, 2023
@yoomee1313
Copy link
Contributor

@blukat29 @2dvorak @hyunsooda Could you review this PR?

hyunsooda
hyunsooda reviewed Jul 26, 2023
View reviewed changes
@Sotatek-TinnNguyen Sotatek-TinnNguyen merged commit aee30b1 into klaytn:dev Jul 26, 2023
@Sotatek-TinnNguyen Sotatek-TinnNguyen deleted the golang1.20 branch July 26, 2023 05:37
@yoomee1313 yoomee1313 mentioned this pull request Jul 27, 2023
Closed
20 tasks
@aidan-kwon aidan-kwon mentioned this pull request Jul 28, 2023
Closed
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hyunsooda hyunsooda hyunsooda left review comments

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@blukat29 blukat29 blukat29 approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@jaydenhur jaydenhur Awaiting requested review from jaydenhur

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

Assignees

@Sotatek-TinnNguyen Sotatek-TinnNguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sotatek-TinnNguyen @yoomee1313 @blukat29 @hyunsooda @aidan-kwon
0