8000 Fix nodecmd tests by blukat29 · Pull Request #1909 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Fix nodecmd tests #1909

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Fix nodecmd tests #1909

merged 3 commits into from
Jul 31, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Jul 28, 2023

Proposed changes

  • Fix nodecmd tests related to --datadir flags.

nodecmd tests are not run by Pull-Request CI. It only runs as part of nightly-coverage CI.
To run manually,

cd cmd/utils/nodecmd && go test -v

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 requested review from kjeom and ian0371 as code owners July 28, 2023 09:02
kjeom
kjeom previously approved these changes Jul 28, 2023
8000
@blukat29 blukat29 merged commit 1a6e084 into klaytn:dev Jul 31, 2023
@blukat29 blukat29 deleted the 20230728-fix-nodecmd-tests branch July 31, 2023 05:40
@aidan-kwon aidan-kwon mentioned this pull request Aug 3, 2023
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0