This repository was archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 182
Added more flags to resolve high memory consumption #1918
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04cae62
to
50373f2
Compare
ian0371
reviewed
Aug 4, 2023
@ian0371 @kjeom @ethan-kr @aidan-kwon Please take a look. |
ian0371
previously approved these changes
Aug 4, 2023
ian0371
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, aliases only exist for "DstRocksDB*", so I'll add aliases to "RocksDB*" in another PR.
My bad. Thanks! |
aidan-kwon
reviewed
Aug 4, 2023
813e684
to
f29addc
Compare
aidan-kwon
approved these changes
Aug 7, 2023
kjeom
approved these changes
Aug 7, 2023
ian0371
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduced two flags
MaxOpenFiles
andCacheIndexAndFilter
flags are addedMaxOpenFiles
controls the number of index/filter blocks by limiting this number.CacheIndexAndFilter
uses block cache instead of using extra.ref: https://github.com/facebook/rocksdb/wiki/Memory-usage-in-RocksDB#indexes-and-filter-blocks
Minor fixes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)