10000 Fix vrank metrics and update timing by hyeonLewis · Pull Request #1919 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Fix vrank metrics and update timing #1919

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Fix vrank metrics and update timing #1919

merged 3 commits into from
Aug 7, 2023

Conversation

hyeonLewis
Copy link
Contributor

Proposed changes

  • Change metrics to be same as logs by calculating values from commitArrivalTimeMap.
  • Change update timing of metrics to prevent metric fetch timing issue.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@hyeonLewis hyeonLewis requested a review from ian0371 August 4, 2023 00:47
@hyeonLewis hyeonLewis mentioned this pull request Aug 4, 2023
Closed
20 tasks
@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 4, 2023
jiseongnoh
jiseongnoh reviewed Aug 4, 2023
View reviewed changes
ian0371
ian0371 reviewed Aug 4, 2023
View reviewed changes
@hyeonLewis hyeonLewis requested a review from jiseongnoh August 4, 2023 05:02
@hyeonLewis hyeonLewis merged commit 7e42267 into klaytn:dev Aug 7, 2023
@hyeonLewis hyeonLewis deleted the fix-vrank-metrics branch August 7, 2023 01:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian0371 ian0371 ian0371 approved these changes

@jiseongnoh jiseongnoh jiseongnoh approved these changes

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@yoomee1313 yoomee1313 Awaiting requested review from yoomee1313

Assignees

@hyeonLewis hyeonLewis

Labels
need to merge Need to merge for the next time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyeonLewis @ian0371 @jiseongnoh @aidan-kwon
0