8000 build: downgrade build image os to ubuntu18.04 by yoomee1313 · Pull Request #1925 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

build: downgrade build image os to ubuntu18.04 #1925

Merged
merged 24 commits into from
Aug 10, 2023
Merged

build: downgrade build image os to ubuntu18.04 #1925

merged 24 commits into from
Aug 10, 2023

Conversation

yoomee1313
Copy link
Contributor
@yoomee1313 yoomee1313 commented Aug 7, 2023 •
edited
Loading

Proposed changes

To work well in ubuntu18.04, ldd version should be less than 2.27, but ubuntu20.04 uses 2.29+. So, this Pr downgrade the build image os to ubuntu18.04.

We can check the ldd by below.

root@28dda4a28e9b:~/go/src/github.com/klaytn/klaytn# ldd build/bin/ken   
        linux-vdso.so.1 (0x00007ffcbe599000)
        libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007f87a4d3f000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f87a4b20000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f87a4782000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f87a4391000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f87a4f59000)
root@28dda4a28e9b:~/go/src/github.com/klaytn/klaytn# ls -l /lib/x86_64-linux-gnu/libm.so.6
lrwxrwxrwx 1 root root 12 May  3  2022 /lib/x86_64-linux-gnu/libm.so.6 -> libm-2.27.so
root@28dda4a28e9b:~/go/src/github.com/klaytn/klaytn# ls -l /lib/x86_64-linux-gnu/libc.so.6
lrwxrwxrwx 1 root root 12 May  3  2022 /lib/x86_64-linux-gnu/libc.so.6 -> libc-2.27.so

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yoomee1313 yoomee1313 force-pushed the build/downgrade-ubuntu-image branch from e23e7ed to 4794a58 Compare August 7, 2023 13:45
@yoomee1313 yoomee1313 force-pushed the build/downgrade-ubuntu-image branch from 4794a58 to 85e0225 Compare August 7, 2023 14:01
aidan-kwon
aidan-kwon previously approved these changes Aug 8, 2023
View reviewed changes
@yoomee1313 yoomee1313 marked this pull request as ready for review August 8, 2023 00:46
@yoomee1313 yoomee1313 self-assigned this Aug 8, 2023
@yoomee1313 yoomee1313 added the need to merge Need to merge for the next time label Aug 8, 2023
JayChoi1736
JayChoi1736 previously approved these changes Aug 8, 2023
View reviewed changes
blukat29
blukat29 previously approved these changes Aug 8, 2023
View reviewed changes
@Sotatek-TinnNguyen
Copy link
Contributor

@yoomee1313 Can you check about the failed test pls? thank you

yoomee1313
yoomee1313 commented Aug 8, 2023
View reviewed changes
JayChoi1736
JayChoi1736 previously approved these changes Aug 8, 2023
View reviewed changes
aidan-kwon
aidan-kwon previously approved these changes Aug 8, 2023
View reviewed changes
blukat29
blukat29 previously approved these changes Aug 8, 2023
View reviewed changes
@yoomee1313 yoomee1313 marked this pull request as draft August 8, 2023 09:18
@yoomee1313 yoomee1313 force-pushed the build/downgrade-ubuntu-image branch from 337c7d1 to df7faa2 Compare August 10, 2023 05:55
@yoomee1313 yoomee1313 force-pushed the build/downgrade-ubuntu-image branch from df7faa2 to b41d824 Compare August 10, 2023 06:10
@codecov-commenter
Copy link
codecov-commenter commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #1925 (73ff982) into dev (fc11bcc) will decrease coverage by 0.08%.
Report is 10 commits behind head on dev.
The diff coverage is n/a.

❗ Current head 73ff982 differs from pull request most recent head 79ecdcf. Consider uploading reports for the commit 79ecdcf to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1925      +/-   ##
==========================================
- Coverage   65.71%   65.63%   -0.08%     
==========================================
  Files         540      540              
  Lines       76176    76176              
==========================================
- Hits        50057    49998      -59     
- Misses      22567    22616      +49     
- Partials     3552     3562      +10

see 26 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9155bd1...79ecdcf. Read the comment docs.

@yoomee1313 yoomee1313 force-pushed the build/downgrade-ubuntu-image branch from 73ff982 to b41d824 Compare August 10, 2023 06:42
@Sotatek-TinnNguyen
merge docker file
a295c2c
@Sotatek-TinnNguyen
Merge branch 'build/downgrade-ubuntu-image' of github.com:yoomee1313/…
< 8000 input type="hidden" name="dropdown_direction" value="w" autocomplete="off" data-targets="batch-deferred-content.inputs" />
8c64796 
…klaytn into build/downgrade-ubuntu-image
@Sotatek-TinnNguyen
merge docker file
f5e1c66
@yoomee1313 yoomee1313 marked this pull request as ready for review August 10, 2023 07:56
@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 10, 2023
yoomee1313
yoomee1313 commented Aug 10, 2023
View reviewed changes
Copy link
Contributor Author
@yoomee1313 yoomee1313 left a comment •
edited
Loading

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sotatek-TinnNguyen Looks good to me except just one more minor thing.

yoomee1313
yoomee1313 commented Aug 10, 2023
View reviewed changes
@aidan-kwon aidan-kwon merged commit 95fd212 into klaytn:dev Aug 10, 2023
@yoomee1313 yoomee1313 deleted the build/downgrade-ubuntu-image branch September 11, 2023 08:41
@blukat29 blukat29 removed the need to merge Need to merge for the next time label Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sotatek-TinnNguyen Sotatek-TinnNguyen Sotatek-TinnNguyen approved these changes

@blukat29 blukat29 blukat29 approved these changes

@aidan-kwon aidan-kwon aidan-kwon approved these changes

@kjeom kjeom Awaiting requested review from kjeom

@hyunsooda hyunsooda Awaiting requested review from hyunsooda

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

Assignees

@yoomee1313 yoomee1313

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yoomee1313 @Sotatek-TinnNguyen @codecov-commenter @blukat29 @aidan-kwon @JayChoi1736
0