8000 Fix TestClientReconnect for CI by JayChoi1736 · Pull Request #1935 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Fix TestClientReconnect for CI #1935

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

JayChoi1736
Copy link
Contributor
@JayChoi1736 JayChoi1736 commented Aug 9, 2023

Proposed changes

  • sometimes TestClientReconnect testcase failed in CI process
  • rearrange server shutdown cooltime in TestClientReconnect(similar to geth)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@JayChoi1736 JayChoi1736 self-assigned this Aug 9, 2023
@JayChoi1736 JayChoi1736 changed the title Add cool time in TestClientReconnect Fix TestClientReconnect for CI Aug 9, 2023
@JayChoi1736 JayChoi1736 marked this pull request as ready for review August 9, 2023 06:00
@JayChoi1736 JayChoi1736 requested a review from blukat29 August 9, 2023 06:57
@JayChoi1736 JayChoi1736 merged commit 9155bd1 into klaytn:dev Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub< 75F0 /strong>. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0