This repository was archived by the owner on Aug 19, 2024. It is now read-only.
[Client] Added misconsidered error handling #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should not be faced
ian0371
previously approved these changes
Aug 8, 2023
aidan-kwon
previously approved these changes
Aug 8, 2023
kjeom
previously approved these changes
Aug 8, 2023
hyeonLewis
reviewed
Aug 9, 2023
55ae4e3
ian0371
approved these changes
Aug 9, 2023
kjeom
approved these changes
Aug 9, 2023
aidan-kwon
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The client function
TransactionInBlock()had not correctly handled the internal function call error. The expected error should bethe block does not existor something others, but it makes a runtime panic (at L241). This PR added an early exit when the return value of the internal function call is found as an error.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...