8000 [Client] Added misconsidered error handling by hyunsooda · Pull Request #1932 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

[Client] Added misconsidered error handling #1932

Merged

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

The client function TransactionInBlock() had not correctly handled the internal function call error. The expected error should be the block does not exist or something others, but it makes a runtime panic (at L241). This PR added an early exit when the return value of the internal function call is found as an error.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyunsooda hyunsooda requested review from kjeom and nohkwak as code owners August 8, 2023 07:51
ian0371
ian0371 previously approved these changes Aug 8, 2023
aidan-kwon
aidan-kwon previously approved these changes Aug 8, 2023
kjeom
kjeom previously approved these changes Aug 8, 2023
@hyunsooda hyunsooda dismissed stale reviews from kjeom, aidan-kwon, and ian0371 via 55ae4e3 August 9, 2023 01:29
@aidan-kwon aidan-kwon merged commit 43b3482 into klaytn:dev Aug 10, 2023
@blukat29 blukat29 mentioned this pull request Sep 8, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0