8000 added no chain reader error on GetConsensusInfo method by jeongkyun-oh · Pull Request #1949 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

added no chain reader error on GetConsensusInfo method #1949

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

jeongkyun-oh
Copy link
Contributor

Proposed changes

  • This PR protects panic issue when GetConsensusInfo method is called before ChainReader is set on backend.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@blukat29 blukat29 merged commit 126912c into klaytn:dev Aug 29, 2023
@blukat29 blukat29 mentioned this pull request Sep 8, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0