This repository was archived by the owner on Aug 19, 2024. It is now read-only.
API RecoverFromTransaction handles eth txtypes #1975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
approved these changes
Sep 19, 2023
hyunsooda
reviewed
Sep 20, 2023
JayChoi1736
approved these changes
Sep 20, 2023
hyunsooda
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently
klay_recoverFromTransactionfails when the input transaction has the txtype 0x02 (AccessList).This PR automatically prepends the EthereumTxTypeEnvelope if the encoded tx is of ethereum type.
Types of changes
Checklist
$ make test)Related issues
Further comments