8000 [API] Refactored `ForkStatus` API by hyunsooda · Pull Request #1971 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

[API] Refactored ForkStatus API #1971

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[API] Refactored ForkStatus API #1971

merged 2 commits into from
Sep 19, 2023

Conversation

hyunsooda
Copy link
Contributor
@hyunsooda hyunsooda commented Sep 18, 2023 •
edited
Loading

Proposed changes

Refactored #1804. This change does not require manual add when a new hardfork is scheduled.

Example output:

> klay.forkStatus(0)
{
  ChainID: 5000,
  IsEthTxType: true,
  IsIstanbul: true,
  IsKIP103: false,
  IsKore: true,
  IsLondon: true,
  IsMagma: true,
  IsShanghai: true
}

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyunsooda hyunsooda changed the title [API] Use reflect to not update manually [API] Refined ForkStatus API Sep 18, 2023
@hyunsooda hyunsooda changed the title [API] Refined ForkStatus API [API] Refactored ForkStatus API Sep 18, 2023
blukat29
blukat29 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor
@blukat29 blukat29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Printing out ChainID is a good side addition, too.

8000
@hyunsooda hyunsooda merged commit f8ebbec into klaytn:dev Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@ian0371 ian0371 ian0371 approved these changes

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@kjeom kjeom Awaiting requested review from kjeom

Assignees

@hyunsooda hyunsooda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyunsooda @blukat29 @ian0371 @JayChoi1736
0