This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Implement EIP 6780 change in SELFDESTRUCT #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsooda
reviewed
Oct 6, 2023
hyunsooda
previously approved these changes
Oct 6, 2023
9 tasks
hyunsooda
previously approved these changes
Oct 10, 2023
blukat29
reviewed
Oct 10, 2023
blukat29
previously approved these changes
Oct 11, 2023
yoomee1313
previously approved these changes
Oct 11, 2023
ian0371
reviewed
Oct 11, 2023
|
@ian0371 |
blukat29
approved these changes
Oct 11, 2023
yoomee1313
approved these changes
Oct 11, 2023
This was referenced Oct 12, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
SELFDESTRUCTwill recover all funds to the caller but not delete the account, except when called in the same transaction as creationTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...