8000 [Cmd] Fixed configuration dump command by hyunsooda · Pull Request #1997 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

[Cmd] Fixed configuration dump command #1997

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

Kafka configuration, introduced a long ago, causes an error to dump the default configuration template to toml format. This PR fixes this with the same mannor of the nullify the genesis block (L48-51)

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29
Copy link
Contributor

@hyunsooda Please merge 'dev' into this PR branch. Linter got picky.

@blukat29
Copy link
Contributor

@2dvorak PTAL

Copy link
Collaborator
@2dvorak 2dvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blukat29 blukat29 merged commit 79ba919 into klaytn:dev Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0