8000 KIP-113 BLS PublicKey Registry accessors by blukat29 · Pull Request #1990 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

KIP-113 BLS PublicKey Registry accessors #1990

Merged
merged 7 commits into from
Oct 31, 2023
Merged

KIP-113 BLS PublicKey Registry accessors #1990

merged 7 commits into from
Oct 31, 2023

Conversation

blukat29
Copy link
Contributor
@blukat29 blukat29 commented Oct 10, 2023 •
edited
Loading

Proposed changes

  • Add KIP113 contract mockup (see KIP-113)
  • Actual KIP113.sol won't be added because the concrete implementation is out of the Klaytn node's scope.
  • Add accessors to the KIP113 system contract.
    • ReadKip113All() calls the getAllInfo() function, and filters out records with invalid public key or pop values.
    • AllocKip113() calculates the storage layout of KIP113Mock contract, for testing.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

Since #1987 conflicts with contracts/system_contracts/all.go, This PR will be merged after that.

@blukat29 blukat29 changed the title KIP113 BLS Registry accessors KIP-113 BLS Registry accessors Oct 10, 2023
@blukat29 blukat29 self-assigned this Oct 10, 2023
@blukat29 blukat29 changed the title KIP-113 BLS Registry accessors KIP-113 BLS PublicKey Registry accessors Oct 11, 2023
@blukat29
Copy link
Contributor Author

Rebased to latest dev.

@blukat29
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@hyeonLewis
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

hyunsooda
hyunsooda reviewed Oct 20, 2023
View reviewed changes
@blukat29 blukat29 force-pushed the sys-sbr-accessors branch 2 times, most recently from 3c69959 to 6830206 Compare October 23, 2023 10:06
@blukat29 blukat29 marked this pull request as ready for review October 23, 2023 10:08
hyeonLewis
hyeonLewis reviewed Oct 24, 2023
View reviewed changes
@blukat29
Copy link
Contributor Author

@yoomee1313 PTAL

@blukat29 blukat29 merged commit b99cdef into klaytn:dev < 981E a href="https://github.com/klaytn/klaytn/pull/1990#event-10816604800" class="Link--secondary">Oct 31, 2023
@blukat29 blukat29 deleted the sys-sbr-accessors branch October 31, 2023 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian0371 ian0371 ian0371 approved these changes

@hyunsooda hyunsooda hyunsooda approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@sjnam sjnam Awaiting requested review from sjnam

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blukat29 @hyeonLewis @ian0371 @hyunsooda @yoomee1313
0