8000 Setting upstream archive mode EN by sjnam · Pull Request #2013 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

Setting upstream archive mode EN #2013

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Setting upstream archive mode EN #2013

merged 6 commits into from
Nov 2, 2023

Conversation

sjnam
Copy link
Contributor
@sjnam sjnam commented Oct 30, 2023

Proposed changes

  • Full EN can only store the latest block states (e.g. latest-128 block ~ latest block)
  • Querying latest block state of archive EN is not efficient compared to query latest block state of full EN
  • You can add the command line flag of an EN --upstream-en archive-en-rpc-url to test. For example, --upstream-en http://localhost:8557

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

blukat29
blukat29 previously approved these changes Oct 30, 2023
hyunsooda
hyunsooda previously approved these changes Nov 1, 2023
@sjnam sjnam dismissed stale reviews from hyunsooda and blukat29 via 8847e15 November 1, 2023 09:05
@blukat29
Copy link
Contributor
blukat29 commented Nov 1, 2023

@sjnam Please rebase against latest dev.

@sjnam sjnam merged commit 95f9ee7 into klaytn:dev Nov 2, 2023
@sjnam sjnam deleted the reliable-archive-en branch November 2, 2023 01:55
@sjnam sjnam changed the title Setting reliable archive mode EN Setting upstream archive mode EN Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0