8000 [API] New CreateAccessList API by hyunsooda · Pull Request #2027 · klaytn/klaytn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 19, 2024. It is now read-only.

[API] New CreateAccessList API #2027

Merged
merged 9 commits into from
Nov 15, 2023
Merged

[API] New CreateAccessList API #2027

merged 9 commits into from
Nov 15, 2023

Conversation

hyunsooda
Copy link
Contributor
@hyunsooda hyunsooda commented Nov 8, 2023 •
edited by 2dvorak
Loading

Proposed changes

Ported ethereum/go-ethereum#22550.

  • This PR is a post-PR of [VM] Use uint256 library for big integer ops #2024. Most of the changes were from there. I did refactoring contracts.go, resulting in getting rid of unmapped contract addresses L135-L136. @yoomee1313 PTAL.

  • This API mirrors {klay,eth}.estimateGas usage, returning storage slot lists confined by the provided contract address. It captures all accessed storage slots during EVM execution by detecting storage opcodes i.e., SLOAD and SSTORE

  • Confirmed the correctness of this porting with the latest geth.

  • The {klay,eth}.createAccessList shares the same implementation with the structure of EthTransactionArgs.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@hyunsooda
Copy link
Contributor Author

TODO: Rebase #2024 once it is merged.

yoomee1313
yoomee1313 reviewed Nov 9, 2023
View reviewed changes
blukat29
blukat29 previously approved these changes Nov 9, 2023
View reviewed changes
yoomee1313
yoomee1313 reviewed Nov 10, 2023
View reviewed changes
ian0371
ian0371 reviewed Nov 13, 2023
View reviewed changes
@blukat29 blukat29 merged commit e5c0cd2 into klaytn:dev Nov 15, 2023
@2dvorak 2dvorak mentioned this pull request Dec 11, 2023
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@ian0371 ian0371 ian0371 approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@kjeom kjeom Awaiting requested review from kjeom

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@sjnam sjnam Awaiting requested review from sjnam

@hyeonLewis hyeonLewis Awaiting requested review from hyeonLewis hyeonLewis is a code owner

Assignees

@hyunsooda hyunsooda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyunsooda @blukat29 @ian0371 @yoomee1313
0