8000 Add COPYING file following GPL by sachac · Pull Request #21 · kljohann/mpv.el · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add COPYING file following GPL #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Add COPYING file following GPL #21

merged 1 commit into from
Dec 26, 2021

Conversation

sachac
Copy link
Contributor
@sachac sachac commented Dec 23, 2021

Hi kljohann! Thanks for making mpv.el - I use it quite often when editing captions, and I've been tinkering around with visualizing waveforms and using that to navigate too.

This pull request adds the GPL license text to COPYING to follow GPL's requirements.

Also, https://lists.gnu.org/archive/html/emacs-devel/2021-12/msg02104.html has a discussion on emacs-devel about possibly including mpv.el in NonGNU ELPA. Is that something you'd consider?

@kljohann
Copy link
Owner

Thanks for the PR and the kind words :)

Also, https://lists.gnu.org/archive/html/emacs-devel/2021-12/msg02104.html has a discussion on emacs-devel about possibly including mpv.el in NonGNU ELPA. Is that something you'd consider?

Sure, from what I understand, NonGNU ELPA can also have a build recipe that is pointing at this repo, right?

@kljohann kljohann merged commit 4774d52 into kljohann:master Dec 26, 2021
@sachac
Copy link
Contributor Author
sachac commented Dec 28, 2021 via email

@skangas
Copy link
skangas commented Dec 28, 2021

Hi!

One difference between NonGNU ELPA and MELPA to be aware is that on NonGNU ELPA, we only provide the latest released version. Luckily, this is quite easily handled: to "release" a new version of the package on NonGNU ELPA, you simply update the "Version" header. For example, I see that the version has been set to "0.1.0" for many years now, so perhaps you should consider bumping it. Then you should remember to do that when you feel that it makes sense.

The big advantage of NonGNU ELPA, of course, is that it is enabled by default starting with Emacs 28, so hopefully you will see some new users.

Thanks again!

kljohann added a commit that referenced this pull request Dec 28, 2021
This makes a recent version available on NonGNU ELPA, see comments on #21.
@kljohann
Copy link
Owner

Thanks for adding the package, I updated the version accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0