8000 chore: Upgrade go versiom to 1.24 by codablock · Pull Request #1300 · kluctl/kluctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Upgrade go versiom to 1.24 #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- uses: actions/setup-node@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview-proxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- name: Install some tools
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview-run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- uses: actions/setup-node@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- name: Setup QEMU
uses: docker/setup-qemu-action@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- uses: actions/setup-node@v4
with:
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- name: Setup QEMU
uses: docker/setup-qemu-action@v3
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.24'
cache-dependency-path: "**/*.sum"
- uses: actions/setup-python@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion cmd/kluctl/commands/cmd_helm_update.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (cmd *helmUpdateCmd) Run(ctx context.Context) error {
out = fmt.Sprintf("%s: Downloading Chart with branch, tag or commit %s into cache", chart.GetChartName(), version.String())
}
g.RunE(func() error {
s := status.Startf(ctx, out)
s := status.Start(ctx, out)
defer s.Failed()
_, err := chart.PullCached(ctx, version)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module github.com/kluctl/kluctl/v2

go 1.22.7
go 1.24

toolchain go1.22.9
toolchain go1.24.2

replace github.com/kluctl/kluctl/lib => ./lib

Expand Down
2 changes: 1 addition & 1 deletion pkg/clouds/gcp/fake_clientfactory.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func (f *FakeClientFactory) AccessSecretVersion(ctx context.Context, req *secret
}

errMsg := fmt.Sprintf("secret not found: failed to access secret version: rpc error: code = NotFound desc = secret %s not found", req.Name)
return nil, status.Errorf(codes.NotFound, errMsg)
return nil, status.Error(codes.NotFound, errMsg)
}

func (f *FakeClientFactory) SecretManagerClient(ctx context.Context) (AccessSecretVersionInterface, error) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/kluctldeployment_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ func (r *KluctlDeploymentReconciler) doReconcile(
finalStatus, reason := r.buildFinalStatus(ctx, obj)
if reason != kluctlv1.ReconciliationSucceededReason {
internal_metrics.NewKluctlLastObjectStatus(obj.Namespace, obj.Name).Set(0.0)
err = fmt.Errorf(finalStatus)
err = fmt.Errorf("%s", finalStatus)

patchErr = r.patchReadyCondition(ctx, obj, metav1.ConditionFalse, reason, finalStatus)
if patchErr != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/deployment/utils/errors_holder.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func (dew *DeploymentErrorsAndWarnings) AddError(ref k8s.ObjectRef, err error) {

func (dew *DeploymentErrorsAndWarnings) AddApiWarnings(ref k8s.ObjectRef, warnings []k8s2.ApiWarning) {
for _, w := range warnings {
dew.AddWarning(ref, fmt.Errorf(w.Text))
dew.AddWarning(ref, fmt.Errorf("%s", w.Text))
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/sops/decryptor/decryptor.go
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ func stripRoot(root, path string) string {

func sopsUserErr(msg string, err error) error {
if userErr, ok := err.(sops.UserError); ok {
err = fmt.Errorf(userErr.UserError())
err = fmt.Errorf("%s", userErr.UserError())
}
return fmt.Errorf("%s: %w", msg, err)
}
Expand Down
0