8000 fix: Don't consider objects as ready when the observedGeneration != generation by codablock · Pull Request #340 · kluctl/kluctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Don't consider objects as ready when the observedGeneration != generation #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix: Don't consider objects as ready when the observedGeneration != generation #340

merged 1 commit into from
Feb 28, 2023

Conversation

codablock
Copy link
Collaborator

Description

This fixes issues with Deployment objects being marked as ready right after applying changes that would make in non-ready.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a new example

@codablock
fix: Don't consider objects as ready when the observedGeneration != g…
cbc3a68 
…eneration

This fixes issues with Deployment objects being marked as ready right after
applying changes that would make in non-ready.
@codablock codablock merged commit c49ee63 into main Feb 28, 2023
@codablock codablock deleted the fix-waitreadiness branch February 28, 2023 10:32
codablock added a commit that referenced this pull request Feb 28, 2023
@codablock
fix: Don't consider objects as ready when the observedGeneration != g…
4e1c428 
…eneration (#340)

This fixes issues with Deployment objects being marked as ready right after
applying changes that would make in non-ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codablock
0