Fix windows and reenable CI #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken when merging kmonad#894
The return in `keyHandler` would have been, as far as I could tell, compiled to a zero. I think changing it to non zero to block other event lowlevel handlers is the right decision and may fix some bugs, ~~though I am not on Windows and am unable to test any of this.~~ After having someone else test it, I can confirm KMonad works just as it did before. Since we ignore the return value from `grab_kb` and don't return anything, we just change it to `void`.
When we change which stack resolvers we use commonly we would add a new ones and remove old ones. This means we delete from the top and add to the bottom. Deleting from the top is a clean diff with trailing comma, while adding to the bottom is a clean diff with leading comma. With our current leading comma approach we would have to always change two lines at the beginning.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While merging #894 it seems the windows code was broken.
To detect this in the future we reenable the windows CI (cherry-picked from #896)
and fixed some warnings (also cherry picked + part of other commit).
While we're touching the CI, we also made the lists more uniform for cleaner diffs in the future
Fixes #946.