Hold while multi-tap is undecided
#958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokesper
added a commit
to jokesper/kmonad
that referenced
this pull request
Feb 24, 2025
We also cancel `multi-tap` on release but only while released. This should fix `multi-tap` in a layer keeping it's definition through layer-switch (see kmonad#954 for an equivalent issue for `stepped`). Also note, this does not revert kmonad#958 or kmonad#974. Effectively they overshot the goal slightly. It also doesn't reintroduce the issues kmonad#958 and kmonad#974 where designed to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955.
If we merge #524 (or #914). We should change
InputHooktoInputHookPrio.Furthermore this breaks the last button being held the same length the key is held (See this comment for details).
To fix this we could reimplement
pressusingInputHookPrioor change #524 as suggested.